Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORGS-205: Update GO SDK to support organization domains crud #326

Conversation

NicolasLopes7
Copy link
Contributor

@NicolasLopes7 NicolasLopes7 commented Sep 17, 2024

This PR updates the go sdk to support the organization domains crud

@NicolasLopes7 NicolasLopes7 requested a review from a team as a code owner September 17, 2024 20:25
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @NicolasLopes7 can you please take another look? We have to make sure that we follow the same conventions throughout the library. 😄

organizationdomain/client.go Outdated Show resolved Hide resolved
organizationdomain/client.go Outdated Show resolved Hide resolved
organizationdomain/client.go Show resolved Hide resolved
organizationdomain/client.go Show resolved Hide resolved
organizationdomain/client.go Outdated Show resolved Hide resolved
organizationdomain/client.go Outdated Show resolved Hide resolved
organizationdomain/client.go Show resolved Hide resolved
organizationdomain/client.go Outdated Show resolved Hide resolved
organization_domain.go Outdated Show resolved Hide resolved
organization_domain.go Outdated Show resolved Hide resolved
@NicolasLopes7
Copy link
Contributor Author

Hey @NicolasLopes7 can you please take another look? We have to make sure that we follow the same conventions throughout the library. 😄

Ohh my bad! I thought I've left this one as a draft, was starting late tonight and would continue today's morning!

@NicolasLopes7 NicolasLopes7 force-pushed the nicolas/orgs-205-update-go-sdk-to-support-organization-domains-crud branch from f0fbb65 to 3e34195 Compare September 18, 2024 16:04
@NicolasLopes7 NicolasLopes7 merged commit ff233cb into v2 Sep 18, 2024
5 checks passed
@NicolasLopes7 NicolasLopes7 deleted the nicolas/orgs-205-update-go-sdk-to-support-organization-domains-crud branch September 18, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants